-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alphabetically reorder acknowledgements list and make it more thorough #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
requested review from
quartzjer,
bifurcation,
rohe,
sakimura,
jogu,
tlodderstedt,
pmhsfelix,
mdobrinic,
decentralgabe,
adeinega,
paulbastian,
TimoGlastra and
ju-cu
November 22, 2023 21:08
decentralgabe
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 😄
Sakurann
commented
Nov 22, 2023
bifurcation
approved these changes
Nov 22, 2023
TimoGlastra
approved these changes
Nov 23, 2023
c2bo
approved these changes
Nov 23, 2023
paulbastian
approved these changes
Nov 24, 2023
tplooker
approved these changes
Nov 25, 2023
peppelinux
approved these changes
Nov 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Sakurann
commented
Nov 30, 2023
jogu
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the awareness purposes, adding for review those who I added in the list. will merge when few approvals come in.
cc some of those whom I could not add as reviewers @c2bo, @TakahikoKawasaki, @cobward